Quantcast

[Matplotlib-devel] github reviews

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Matplotlib-devel] github reviews

tcaswell
Folks,

When leaving a review via the github API please leave a note so it is easier to tell if your concerns have been addressed or not.

Tom

_______________________________________________
Matplotlib-devel mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/matplotlib-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: github reviews

Akkana Peck
Thomas Caswell writes:
> When leaving a review via the github API please leave a note so it is
> easier to tell if your concerns have been addressed or not.

What's the procedure for requesting a review? I made a pull request
in mpl_finance that's been sitting since January; it's not anything
important and I'm sure it needs work, but I'm not clear how to find
a reviewer who has time and inclination, and how to ask again in
case github didn't send a notification for the first review request
or the notification got lost, so I've just been letting it sit.

        ...Akkana
_______________________________________________
Matplotlib-devel mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/matplotlib-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: github reviews

Benjamin Root
The squeaky wheel gets the grease. Probably your best bet is to post a comment in the PR first. We probably just didn't notice it at the time. Push comes to shove, hop onto the gitter channel or the matplotlib-dev mailing list and ping there.

Cheers!
Ben Root


On Mon, Apr 24, 2017 at 4:45 PM, Akkana Peck <[hidden email]> wrote:
Thomas Caswell writes:
> When leaving a review via the github API please leave a note so it is
> easier to tell if your concerns have been addressed or not.

What's the procedure for requesting a review? I made a pull request
in mpl_finance that's been sitting since January; it's not anything
important and I'm sure it needs work, but I'm not clear how to find
a reviewer who has time and inclination, and how to ask again in
case github didn't send a notification for the first review request
or the notification got lost, so I've just been letting it sit.

        ...Akkana
_______________________________________________
Matplotlib-devel mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/matplotlib-devel


_______________________________________________
Matplotlib-devel mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/matplotlib-devel
Loading...