[Matplotlib-devel] Fw: Table defaults (font-issue?)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Matplotlib-devel] Fw: Table defaults (font-issue?)

matplotlib - devel mailing list
Sent this message (see below) almost a month ago, but message too large.  I have just used pngcrush on the image which reduced the image from 34k to 26k so hopefully this will send now.



----- Forwarded Message -----
From: OceanWolf <[hidden email]>
To: Matplotlib Development List <[hidden email]>
Sent: Thursday, 2 June 2016, 18:03
Subject: Table defaults (font-issue?)

Sorry for the late comment, I have just reinstalled matploblib for python3, finally making that transition :D.

I have just taken a look at tables thinking I might quickly try to convert the legend to a table, but perhaps too late to make 2.0, but I thought I would give it a go anyway.

Anyway, tables, looking at http://matplotlib.org/devdocs/examples/pylab_examples/table_demo.html it just about okay here, but on my system I don't see a gap between the descender and the bottom of the table cell, I would expect the same padding around the bottom of the decender irrespective of the font used.  I would need to do a bit more investigation here to see if the table even shows the full descender, or whether it clips it.  I use the current master branch for my test.

Best,
OceanWolf



_______________________________________________
Matplotlib-devel mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/matplotlib-devel

table_new_2.png (34K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Fw: Table defaults (font-issue?)

tcaswell
What would be the upside of converting the legend to be a table instead of the current implementation?

Tom

On Wed, Jun 29, 2016 at 5:33 AM OceanWolf via Matplotlib-devel <[hidden email]> wrote:
Sent this message (see below) almost a month ago, but message too large.  I have just used pngcrush on the image which reduced the image from 34k to 26k so hopefully this will send now.



----- Forwarded Message -----
From: OceanWolf <[hidden email]>
To: Matplotlib Development List <[hidden email]>
Sent: Thursday, 2 June 2016, 18:03
Subject: Table defaults (font-issue?)

Sorry for the late comment, I have just reinstalled matploblib for python3, finally making that transition :D.

I have just taken a look at tables thinking I might quickly try to convert the legend to a table, but perhaps too late to make 2.0, but I thought I would give it a go anyway.

Anyway, tables, looking at http://matplotlib.org/devdocs/examples/pylab_examples/table_demo.html it just about okay here, but on my system I don't see a gap between the descender and the bottom of the table cell, I would expect the same padding around the bottom of the decender irrespective of the font used.  I would need to do a bit more investigation here to see if the table even shows the full descender, or whether it clips it.  I use the current master branch for my test.

Best,
OceanWolf


_______________________________________________
Matplotlib-devel mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/matplotlib-devel

_______________________________________________
Matplotlib-devel mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/matplotlib-devel
Reply | Threaded
Open this post in threaded view
|

Re: Fw: Table defaults (font-issue?)

matplotlib - devel mailing list
I see it as easier code to maintain and to visualise, I see the Legend class extending the Table class, i.e. an "is" relationship, rather than a "has" relationship which makes more sense to me.  Rather than have two pieces of code that lay things out in rows and columns we only have one, from an API perspective we ensure we use the same methods for both, methods like setting/getting column-width and row-width, etcetera.  By having it work like this, then any changes to the Table class automatically transfer to the Legend class, for example if were to implement a fancy-table style or something, then that would also apply to the legend, or any other table styling for that matter.

I imagine implementation-wise we should consider the key, value of the legend as a block occupying one table cell, rather then taking up two cells (two columns), and then have extra methods/properties to control within the key, value block, but not 100% as it makes it more complicated.
Anyway, the main issue for 2.0 lies with the inconsistency between machines (probably font based) for the table_demo image.


From: Thomas Caswell <[hidden email]>
To: OceanWolf <[hidden email]>; "[hidden email]" <[hidden email]>
Sent: Thursday, 30 June 2016, 3:31
Subject: Re: [Matplotlib-devel] Fw: Table defaults (font-issue?)

What would be the upside of converting the legend to be a table instead of the current implementation?

Tom

On Wed, Jun 29, 2016 at 5:33 AM OceanWolf via Matplotlib-devel <[hidden email]> wrote:
Sent this message (see below) almost a month ago, but message too large.  I have just used pngcrush on the image which reduced the image from 34k to 26k so hopefully this will send now.



----- Forwarded Message -----
From: OceanWolf <[hidden email]>
To: Matplotlib Development List <[hidden email]>
Sent: Thursday, 2 June 2016, 18:03
Subject: Table defaults (font-issue?)

Sorry for the late comment, I have just reinstalled matploblib for python3, finally making that transition :D.

I have just taken a look at tables thinking I might quickly try to convert the legend to a table, but perhaps too late to make 2.0, but I thought I would give it a go anyway.

Anyway, tables, looking at http://matplotlib.org/devdocs/examples/pylab_examples/table_demo.html it just about okay here, but on my system I don't see a gap between the descender and the bottom of the table cell, I would expect the same padding around the bottom of the decender irrespective of the font used.  I would need to do a bit more investigation here to see if the table even shows the full descender, or whether it clips it.  I use the current master branch for my test.

Best,
OceanWolf


_______________________________________________
Matplotlib-devel mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/matplotlib-devel



_______________________________________________
Matplotlib-devel mailing list
[hidden email]
https://mail.python.org/mailman/listinfo/matplotlib-devel